Expose instrumentation scope name

[utezduyar]

It is good to know the scope to apply view filters. For example if we would like to drop all or some of the meters from this library, below code is how the filtering is applied. The scope name is used explicitly and a change in the scope name by the runtime instrumentation library will break applications.

metricsdk.Instrument{Name: "*",
Scope: instrumentation.Scope{
	Name:    "go.opentelemetry.io/contrib/instrumentation/runtime",
}},
metricsdk.Stream{Aggregation: metricsdk.AggregationDrop{}},

Instead of this, get the scope name from the library itself

metricsdk.Instrument{Name: "*",
Scope: instrumentation.Scope{
	Name:    runtime.Name(),
}},
metricsdk.Stream{Aggregation: metricsdk.AggregationDrop{}},

[pellared]

Could you please make the the PR description more detailed?

You could e.g. give examples with code what is possible with the new method and what is the alternative when it is missing (changing to draft before it is done).

[utezduyar]

@pellared How does it look now?

[pellared]

How does it look now?

Now, I find it clear 👍

I will first change the the title and ask others if they like the proposal.

If the proposal would be accepted then:

1. We would have to do this for all instrumentation libraries.
2. Changelog would have to be updated.

[pellared]

@open-telemetry/go-approvers PTAL

Give the PR a 👍 if you like the proposal.
Give 👎 if you are against.

Additionally more detailed (text) feedback is welcome.

[codecov]

Codecov Report

Merging #4448 (b8d4418) into main (2b69029) will not change coverage.
The diff coverage is 80.0%.

@@          Coverage Diff          @@
##            main   #4448   +/-   ##
=====================================
  Coverage   80.8%   80.8%           
=====================================
  Files        150     150           
  Lines      10371   10371           
=====================================
  Hits        8387    8387           
  Misses      1840    1840           
  Partials     144     144           

Files	Coverage Δ
.../github.com/aws/aws-lambda-go/otellambda/lambda.go	89.0% <100.0%> (ø)
...tation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go	94.6% <100.0%> (ø)
...hub.com/emicklei/go-restful/otelrestful/restful.go	100.0% <100.0%> (ø)
...trumentation/github.com/gorilla/mux/otelmux/mux.go	89.2% <100.0%> (ø)
...entation/github.com/labstack/echo/otelecho/echo.go	100.0% <100.0%> (ø)
...entation/google.golang.org/grpc/otelgrpc/config.go	69.6% <100.0%> (ø)
...ion/google.golang.org/grpc/otelgrpc/interceptor.go	87.8% <100.0%> (ø)
...ntation/gopkg.in/macaron.v1/otelmacaron/macaron.go	91.4% <100.0%> (ø)
...on/net/http/httptrace/otelhttptrace/clienttrace.go	79.0% <100.0%> (ø)
instrumentation/net/http/otelhttp/common.go	100.0% <100.0%> (ø)
... and 5 more

[utezduyar]

1. We would have to do this for all instrumentation libraries.

What other libraries are you aware of? I can get to them too.

[pellared]

1. We would have to do this for all instrumentation libraries.

What other libraries are you aware of? I can get to them too.

All under https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation

[utezduyar]

I think I found all that are using MeterProvider.

[pellared]

I think I found all that are using MeterProvider.

The same has to be done for all TraceProvider.Tracer usages (like you did in otelhttp).

[utezduyar]

I think I found all that are using MeterProvider.

The same has to be done for all TraceProvider.Tracer usages (like you did in otelhttp).

otelhttp has a meterprovider that is why I did it. Do we have a use case for exposing the scope names for tracers? Of course I don't mind making the change. I am just curious.

[pellared]

Do we have a use case for exposing the scope names for tracers?

API consistency.

For now, leave it as it is. I added your proposal as a topic for today's SIG meeting

[pellared]

@utezduyar During SIG meeting we agreed that

1. we accepted your proposal
2. we want to have ScopeName for all instrumentation libraries and reuse it when creating meters and tracers
3. CHANGELOG.md entry must be added

I am converting the PR to draft. Please make it "Ready for review" when you update the PR.

[pellared]

What about ScopeName for otelgrpc?

[utezduyar]

What about ScopeName for otelgrpc?

It is back again.

[pellared]

I noticed that we are also missing ScopeName in otelmacaron and otelhttptrace.

[utezduyar]

otelhttptrace

Can you point me the file name for this? I still couldn't find it.

[pellared]

otelhttptrace

Can you point me the file name for this? I still couldn't find it.

instrumentation/net/http/httptrace/otelhttptrace/clienttrace.go

[pellared]

@utezduyar Thank you for your contribution 🎉

[utezduyar]

@utezduyar Thank you for your contribution 🎉

Thanks for your assistance.