Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Go 1.19 #4352

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 29, 2023

  • Remove CI workflow for Go 1.19
  • Update Makefile compat instruction to use 1.20
  • Update README.md
  • Update all the go.mod directives to use "go 1.20"

Fix #4298

- Remove CI workflow for Go 1.19
- Update Makefile compat instruction to use 1.20
- Update README.md
- Update all the go.mod directives to use "go 1.20"
@MrAlias MrAlias marked this pull request as ready for review September 29, 2023 14:50
@MrAlias MrAlias requested a review from a team September 29, 2023 14:50
@MrAlias MrAlias added this to the v0.46.0 milestone Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #4352 (d9dfdc9) into main (6e91434) will increase coverage by 1.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4352     +/-   ##
=======================================
+ Coverage   82.2%   83.3%   +1.0%     
=======================================
  Files        144     145      +1     
  Lines      10002   10007      +5     
=======================================
+ Hits        8229    8338    +109     
+ Misses      1634    1528    -106     
- Partials     139     141      +2     

see 5 files with indirect coverage changes

@yurishkuro
Copy link
Member

@MrAlias is there a script that does this across the board?

@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 29, 2023

@MrAlias is there a script that does this across the board?

@yurishkuro:

for f in $( find -type f -name 'go.mod' ); do sed -i 's/^\(go \)1.1[0-9]/\11.20/' $f; done

@yurishkuro
Copy link
Member

so no.

@pellared pellared merged commit 8a2f8cf into open-telemetry:main Oct 2, 2023
21 checks passed
@MrAlias MrAlias deleted the drop-go-1.19 branch October 2, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Go 1.19
5 participants