Disable "taking" from reservoir if there is no capacity, regardless of borrow value #3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
approved these changes
Apr 7, 2023
MrAlias
approved these changes
Apr 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3684 +/- ##
=====================================
Coverage 70.0% 70.0%
=====================================
Files 147 147
Lines 6963 6966 +3
=====================================
+ Hits 4877 4880 +3
Misses 1961 1961
Partials 125 125
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
borrow=true, the Golang remote sampler allows a quota of 1req/s. However, this also applies when capacity is 0 (which implies that quota should always be 0, as quota is a portion of capacity). For context,borrow=truewhen quota is unknown but will be determined later.This fix makes sure that the sampler cannot "take" when capacity is 0, which will also disable "borrowing". That is, when capacity is 0, do not take from reservoir at all, regardless of borrow = true/false.