Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: use peroperationsamplerupdater first #2137

Merged
merged 6 commits into from
Apr 6, 2022
Merged

feature: use peroperationsamplerupdater first #2137

merged 6 commits into from
Apr 6, 2022

Conversation

vuuihc
Copy link
Contributor

@vuuihc vuuihc commented Mar 30, 2022 •
edited
Loading

resolve #2135

@vuuihc vuuihc changed the title feature: use peroperationsamplerupdater first feature: use peroperationsamplerupdater first, resolve #2135 Mar 30, 2022
@vuuihc vuuihc changed the title feature: use peroperationsamplerupdater first, resolve #2135 feature: use peroperationsamplerupdater first Mar 30, 2022
@dmathieu
Copy link
Member

Do you think you could add tests for this behavior?

@vuuihc
Copy link
Contributor Author

vuuihc commented Mar 31, 2022

Do you think you could add tests for this behavior?

sure, I will add tests

@vuuihc
Copy link
Contributor Author

vuuihc commented Mar 31, 2022 •
edited
Loading

@dmathieu @Aneurysm9 I added a test for this behavior. Please rerun the test workflows. thanks

@vuuihc
Copy link
Contributor Author

vuuihc commented Apr 1, 2022

@dmathieu @Aneurysm9 @jmacd This time I run make precommit and make ci before push, please review the code and rerun the workflow, thanks!

@vuuihc
Copy link
Contributor Author

vuuihc commented Apr 1, 2022

@dmathieu @jmacd @Aneurysm9 I'm First-time contributors, please rerun the tests workflow thanks. I replied to the reviewed comment, please tell me if I'm wrong, thanks

@vuuihc vuuihc requested review from Aneurysm9 and dmathieu April 2, 2022 00:44
@vuuihc
Copy link
Contributor Author

vuuihc commented Apr 5, 2022

@dmathieu @Aneurysm9 The modifications you requested have been completed, please take the time to review the code. Thank you

@codecov
Copy link

codecov bot commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #2137 (e4f2246) into main (8cf7954) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2137     +/-   ##
=======================================
- Coverage   69.4%   69.3%   -0.1%     
=======================================
  Files        135     135             
  Lines       6113    6111      -2     
=======================================
- Hits        4243    4241      -2     
  Misses      1742    1742             
  Partials     128     128
Impacted Files Coverage Δ
samplers/jaegerremote/sampler_remote_options.go 100.0% <100.0%> (ø)

@Aneurysm9 Aneurysm9 merged commit 1e34aa3 into open-telemetry:main Apr 6, 2022
@MrAlias MrAlias mentioned this pull request Apr 28, 2022
Merged
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmacd jmacd jmacd approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@dmathieu dmathieu dmathieu approved these changes

@MrAlias MrAlias Awaiting requested review from MrAlias

@evantorrie evantorrie Awaiting requested review from evantorrie

@XSAM XSAM Awaiting requested review from XSAM

@dashpole dashpole Awaiting requested review from dashpole

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod

@pellared pellared Awaiting requested review from pellared

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

jaegerremote should use perOperationSamplerUpdater first when update strategy from remote
6 participants
@vuuihc @dmathieu @Aneurysm9 @jmacd @pellared @hanyuancheung