Make ECS detector not error when not on platform #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenTelemetry specification states "failure to detect any resource information MUST NOT be considered an error". Update the ECS detector to not return an error when not running on the ECS platform. Additionally, return nil instead of an empty resource to accommodate a quick merge when this detector is used. A nil value means the other resource this will be merged with will be returned immediately instead of working through the actual merge.
MrAlias
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1428 +/- ##
=====================================
Coverage 69.2% 69.2%
=====================================
Files 127 127
Lines 5475 5475
=====================================
Hits 3794 3794
Misses 1534 1534
Partials 147 147
|
Aneurysm9
approved these changes
Nov 19, 2021
XSAM
approved these changes
Nov 23, 2021
dashpole
approved these changes
Nov 23, 2021
rltoSD
referenced
this pull request
in open-o11y/opentelemetry-go-contrib
Dec 21, 2021
* Make ECS detector not error when not on platform The OpenTelemetry specification states "failure to detect any resource information MUST NOT be considered an error". Update the ECS detector to not return an error when not running on the ECS platform. Additionally, return nil instead of an empty resource to accommodate a quick merge when this detector is used. A nil value means the other resource this will be merged with will be returned immediately instead of working through the actual merge. * Add changes to changelog * Match ECS detector tests with expected behavior * Add PR number to changelog * Remove unused errNotOnECS
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
…1428) * adding codeql workfklow * removing PR and commit triggers * updating changelog * removing push trigger Co-authored-by: Azfaar Qureshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenTelemetry specification states "failure to detect any resource
information MUST NOT be considered an error". Update the ECS detector to
not return an error when not running on the ECS platform.
Additionally, return nil instead of an empty resource to accommodate a
quick merge when this detector is used. A nil value means the other
resource this will be merged with will be returned immediately instead
of working through the actual merge.
Resolve #1426