Add instrumentation for github.com/gocql/gocql #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reggiemcdonald
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
paivagustavo
as code owners
MrAlias
reviewed
Jul 22, 2020
added 2 commits
July 24, 2020 16:50
… to semantic conventions
Aneurysm9
suggested changes
Jul 28, 2020
MrAlias
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Agree with @Aneurysm9 on the tracer/meter naming, but otherwise looks good.
The included comment is more for historical purposes when it can be addressed.
Thanks for the contribution!
Aneurysm9
approved these changes
Jul 29, 2020
MrAlias
reviewed
Jul 29, 2020
MrAlias
approved these changes
Jul 30, 2020
Merged
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* Fix compilation with Golang 1.13 * run go mod tidy again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #91
This PR adds an integration for the Cassandra DB golang client, gocql.
Since the previous implementation of this integration was created, the gocql community added Observer hooks that can be used to collect metrics for queries, batch queries, and connection attempts. You can see the one for queries here. This integration uses these observers, which differs from the prior art, which created a wrapper around the
gocql.Query.Any feedback is appreciated!