-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emicklei/go-restful instrumentation #115
Conversation
A filter may be added at any one of the following: * container scope * webservice scope * route scope Includes a docker-compose example with instructions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, nothing blocking.
Did we want to move this to github.com/emicklei/go-restful
? I know we had talked about this for the other instrumentation that is missing it as well. Maybe a subsequent PR to move everything?
Yes, I planned a subsequent PR to move everything from github.com under a github.com directory. |
fixes #79
A filter may be added at any one of the following:
Includes a docker-compose example with instructions.