-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semconvgen: Add a flag for a path to a custom capitalizations file #529
semconvgen: Add a flag for a path to a custom capitalizations file #529
Conversation
…xisting capitalizations slice
Hi @codeboten 👋 Do you have any thoughts on this? (I misread the CONTRIB file and thought I was supposed to add |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
- Coverage 66.05% 60.64% -5.41%
==========================================
Files 39 40 +1
Lines 1785 1964 +179
==========================================
+ Hits 1179 1191 +12
- Misses 461 626 +165
- Partials 145 147 +2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Damien Mathieu <[email protected]>
…ent to the capitalizations function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we are not properly handling empty lines (or lines with only whitespaces).
Side note: I would not catch it without seeing the tests 😉
ci/lint failed |
@carrbs Thanks for working on this👍 |
Closes #528
This PR:
semconvgen
to read custom strings from a plaintext filecapitalizations
slice