[crosslink] add --skip flag #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows modules in monorepos to opt out of crosslink. This will be used in mdatagen in the Collector core repo for example, where mdatagen has dependencies on internal collector modules, but we don't want to use replace statements as it breaks the ability to `go install` mdatagen Signed-off-by: Alex Boten <[email protected]>
added 2 commits
January 15, 2024 10:28
Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 63.78% 63.89% +0.11%
==========================================
Files 39 39
Lines 2267 2274 +7
==========================================
+ Hits 1446 1453 +7
Misses 677 677
Partials 144 144 ☔ View full report in Codecov by Sentry. |
pellared
reviewed
Jan 16, 2024
Signed-off-by: Alex Boten <[email protected]>
|
The readme has been updated, PTAL |
TylerHelmuth
approved these changes
Jan 17, 2024
pellared
approved these changes
Jan 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows modules in monorepos to opt out of crosslink. This will be used in mdatagen in the Collector core repo for example, where mdatagen has dependencies on internal collector modules, but we don't want to use replace statements as it breaks the ability to
go installmdatagenRelated to open-telemetry/opentelemetry-collector#9281