Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chloggen clarify termininology #375

Merged

Conversation

djaglowski
Copy link
Member

This is intended as a quick follow up to #372. Mostly it just standardizes on the terms "entry/entries" instead of "chlog/chlogs".

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 83.47% and project coverage change: +0.63% 🎉

Comparison is base (e6e68a6) 62.07% compared to head (bdbad0c) 62.70%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   62.07%   62.70%   +0.63%     
==========================================
  Files          48       48              
  Lines        2344     2392      +48     
==========================================
+ Hits         1455     1500      +45     
- Misses        741      743       +2     
- Partials      148      149       +1     
Files Changed Coverage Δ
chloggen/cmd/update.go 64.70% <55.00%> (-5.30%) ⬇️
chloggen/internal/chlog/entry.go 86.20% <94.28%> (+4.66%) ⬆️
chloggen/cmd/new.go 78.78% <100.00%> (ø)
chloggen/cmd/validate.go 88.00% <100.00%> (+3.78%) ⬆️
chloggen/internal/config/config.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djaglowski djaglowski force-pushed the chloggen-clarify-termininology branch from 0e48c16 to bdbad0c Compare July 27, 2023 16:40
@djaglowski djaglowski marked this pull request as ready for review July 27, 2023 16:55
@djaglowski djaglowski requested review from a team and jpkrohling July 27, 2023 16:56
@djaglowski djaglowski merged commit a3a9c90 into open-telemetry:main Jul 27, 2023
9 checks passed
@djaglowski djaglowski deleted the chloggen-clarify-termininology branch July 27, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants