[multimod] apply review feedback #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only comment this PR doesn't address is whether to keep |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 60.77% 60.69% -0.09%
==========================================
Files 48 48
Lines 2320 2315 -5
==========================================
- Hits 1410 1405 -5
Misses 758 758
Partials 152 152
☔ View full report in Codecov by Sentry. |
The following changes were applied: - remove unnecessary bool return - improve documentation - move Client interface Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/review-feedback
branch
from
e408a20
to
3523401
Compare
mx-psi
approved these changes
Jul 17, 2023
Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes were applied:
Fixes #366