Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbotconf] Update all detected Dockerfile #211

Merged
merged 8 commits into from
Jan 6, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 8, 2022

Currently the dbotconf command only adds an entry to update the Dockerfile at the root of a repository. There are projects, like the opentelemetry-go repository, that have many Dockerfiles that exist in subdirectories to the root.

This updates the command to discover all Dockerfiles and add an entry for them when generating and verify an entry with verifying.

Resolve #212

Currently the dbotconf command only adds an entry to update the
Dockerfile at the root of a repository. There are projects, like the
opentelemetry-go repository, that have many Dockerfiles that exist in
subdirectories to the root.

This updates the command to discover all Dockerfiles and add an entry
for them when generating and verify an entry with verifying.
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 58.19% // Head: 58.85% // Increases project coverage by +0.65% 🎉

Coverage data is based on head (d9ac34c) compared to base (b354012).
Patch coverage: 81.81% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
+ Coverage   58.19%   58.85%   +0.65%     
==========================================
  Files          44       44              
  Lines        1928     2000      +72     
==========================================
+ Hits         1122     1177      +55     
- Misses        680      692      +12     
- Partials      126      131       +5     
Impacted Files Coverage Δ
internal/repo/repo.go 61.29% <67.64%> (+3.66%) ⬆️
dbotconf/internal/generate.go 81.03% <84.21%> (-2.30%) ⬇️
dbotconf/internal/verify.go 81.33% <90.00%> (+2.90%) ⬆️
dbotconf/internal/mods.go 57.14% <100.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MrAlias MrAlias marked this pull request as ready for review December 8, 2022 19:34
@MrAlias MrAlias requested review from a team and dmitryax December 8, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbotconf adds docker update at top-level only
2 participants