Hard code semconv 0.2 values #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsloughter
approved these changes
Sep 30, 2024
bryannaegele
force-pushed
the
hardcode-semconv
branch
from
446a2d2
to
25d755e
Compare
|
For future reference, we were also advised by Liudmila to not depend on semconv in the API or SDK and just copy in or hardcode the keys to prevent any version mismatch issues. This isn't a strict requirement, just advised |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily hard code semconv values from 0.2 so that the api and sdk can get a point release rather than forcing updates to 1.27. I think it will be simpler to do this to keep backwards compatibility for now and not have to do a semconv 1.27 pass. We can delay a minor release for now with this approach.