Resource as an argument to starting the tracer provider #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting the global tracer to noop on shutdown of the SDK we rely on the fact the API already handles the SDK being gone. Not setting the tracer to noop saves a global GC from the persistent term update that could negatively impact users.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
==========================================
+ Coverage 38.13% 38.17% +0.04%
==========================================
Files 61 61
Lines 3598 3599 +1
==========================================
+ Hits 1372 1374 +2
+ Misses 2226 2225 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
tsloughter
force-pushed
the
terminate-noop-default
branch
from
9301557 to
62f6c94
Compare
|
Eh.. this may be wrong, it requires making the resource type available in the API. Rethinking. |
tsloughter
force-pushed
the
terminate-noop-default
branch
from
fd3494d to
da9f663
Compare
this better follows the spec
tsloughter
force-pushed
the
terminate-noop-default
branch
from
da9f663 to
6d71b71
Compare
tsloughter
force-pushed
the
terminate-noop-default
branch
from
7ed076c to
2300d09
Compare
tsloughter
force-pushed
the
terminate-noop-default
branch
from
68e5c6c to
41844ab
Compare
tsloughter
force-pushed
the
terminate-noop-default
branch
from
41844ab to
b2da332
Compare
ferd
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a commit to remove the setting of the global tracer to
noopwhen the SDK stops. I think this makes it safer to not potentially drastically harm performance for users on shutdown. The hope would be it is the last thing done but since this can't be guaranteed and technically could be stopped at anytime, so not having a global GC happen seems best.