Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LiveView async wrapper functions for process propagation in OpentelemetryPhoenix #439

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danschultzer
Copy link

@danschultzer danschultzer commented Dec 16, 2024

This adds helper macros to add process propagation to the LiveView async macros. It follows the same in-place replacement as OpentelemetryProcessPropagator.Task and OpentelemetryOban.

I wonder if there should be _with_span and _with_linked_span versions like the task module in process propagator?

Resolves: #302

@danschultzer
Copy link
Author

danschultzer commented Dec 17, 2024

Turning this to draft until I can figure out how to make this not depend on :phoenix_live_view as per #433 (comment):

Our instrumentation libraries cannot include dependencies on the library being instrumented. There are a few reasons for this but as you come up with ideas or proposals just know that is a hard constraint.

Maybe this should be a propagator library instead? Fits better with the process propagator library (in that case oban/req will probably need to be the same).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lost parent context when Phoenix LiveView assign_async is used
1 participant