[WIP] Add route to the span name to Phoenix socket requests #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschultzer
commented
Dec 16, 2024
| @@ -145,6 +156,18 @@ defmodule OpentelemetryPhoenix do | |||
| |> OpenTelemetry.Ctx.attach() | |||
| end | |||
|
|
|||
| @doc false | |||
| def handle_socket_dispatch_start(_event, _measurements, meta, config) do | |||
| if config.adapter == :cowboy2, do: cowboy2_start() | |||
There was a problem hiding this comment.
This was necessary as it didn't update the actual span. I assume the difference from the router event is that the socket handling happens much earlier than router, and there is some handling of cowboy process in phoenix that links it correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP as it needs an upstream fix in Phoenix: phoenixframework/phoenix#6019
This will add a route template to the attributes, and use that for the span name. We may want to add code attributes from #432 though I'm not sure as we deal with both the
socketmodule that is the transport (e.g.Phoenix.Transports.WebSocket) and theuser socketmodule that's the actual socket passed into thesocketmacro.