Trace all Oban telemetry events #437
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschultzer
changed the title
danschultzer
commented
Dec 16, 2024
|
|
||
| case op do | ||
| :start -> | ||
| OpentelemetryTelemetry.start_telemetry_span(__MODULE__, Enum.join(Enum.reverse(rest), "."), metadata, %{kind: :consumer}) |
There was a problem hiding this comment.
Probably should add messaging.system attribute here to make it easy to filter?
There was a problem hiding this comment.
Same goes for the plugin handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #435 which needs to get in first. Check the latest commit for the changes here.
Oban triggers a lot of the ecto otel spans. I think we should set up spans for all internal events so we can have oban parent spans for these ecto spans.
The span names is just the telemetry event joined with
., e.g.oban.peer.election. Maybe there is a better convention for span names for these internal processes, or there may be some these telemetry events that should have a specific span names (and attributes).I've also changed the telemetry handler id, I usually see tuples being used rather than binary.
Sidenote: I think a good future refactor would be to combine all the handlers into just one module instead, I don't think it is necessary to have this concept of
Handler.attachvs just callingattach_manywith all the oban events we want to listen to.