Update OpenTelemetryEcto attributes to conform with semantic conventions 1.27 #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #429 which needs to get in first. Check the latest commit for the changes here.
This conforms the attributes and span names to the 1.27 docs: https://github.com/open-telemetry/semantic-conventions/blob/v1.27.0/docs/database/database-spans.md
It does introduce a bunch of breaking changes so let me know if backwards compability is required. I can keep the old attributes, but not sure if we should just go with major release instead since there's a lot of things that are different now?
I can also update the changelog in this PR.
Changes
db.name
/db.instance
->db.namespace
source
->db.collection.name
db.statement
->db.query.text
db.url
->server.address
/server.port
total_time_
->db.client.operation.duration
(in seconds as float)idle_time_
->db.client.connection.create_time
(in seconds as float)queue_time_
->db.client.connection.wait_time
(in seconds as float)query_time_
->db.client.connection.use_time
(in seconds as float): db_statement
config option to:db_query
(not necessary but it conforms closer to the otel attribute name)ecto.repo.query
to{db.operation.name} {target}
or just{target}
if it is a general db operation conforming to 1.27 guidelinesRemoves
db.type
decode_time_
(I couldn't find a metric that matched it):span_prefix
config option:time_unit
config optionAdds
db.operation.name
Resolves #364