chore: run propagator dialyzer on CI #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
elixir
scope-ci
propagators
opentelemetry_process_propagator
labels
tsloughter
approved these changes
Oct 3, 2023
It is necessary because :dialyxir requires Elixir ">= 1.12.0"
|
1.11 should not have been removed from the matrix and the minimum support should not have been changed @joaothallis. Why was that done and the PR not simply rebased with adding dialyzer? Edit: Nevermind. I see. The issue with dialyxir was fixed to remove the reliance on that operator. I'm going to revert this for now and we can do a new PR with the most recent version. |
bryannaegele
added a commit
that referenced
this pull request
Nov 10, 2023
This reverts commit 97d13c3.
bryannaegele
added a commit
that referenced
this pull request
Nov 10, 2023
Okay, I will create a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update propagator dialyzer and run it on CI