Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract lookupcgroupv2 out of the otlp reporter #227

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Nov 8, 2024

So it can be reused by several reporters.

@dmathieu dmathieu mentioned this pull request Nov 8, 2024
@dmathieu dmathieu marked this pull request as ready for review November 8, 2024 09:17
@dmathieu dmathieu requested review from a team as code owners November 8, 2024 09:17
reporter/cgroupv2.go Outdated Show resolved Hide resolved
reporter/cgroupv2.go Outdated Show resolved Hide resolved
@dmathieu dmathieu force-pushed the extract-lookupcgroup branch from 6b675a7 to 1cf6ac9 Compare November 19, 2024 08:54
@dmathieu
Copy link
Member Author

I couldn't move is to the util package, as that creates a cyclic dependency with libpf. I moved it to util/cgroup.

@dmathieu
Copy link
Member Author

Per @rockdaboot's suggestion in #227 (comment), I have moved it to libpf.

@rockdaboot rockdaboot merged commit 2c6d1ac into open-telemetry:main Nov 20, 2024
23 checks passed
@dmathieu dmathieu deleted the extract-lookupcgroup branch November 20, 2024 15:51
ltrk2 added a commit to instana/opentelemetry-ebpf-profiler that referenced this pull request Dec 4, 2024
* Fix unwinding at syscall on aarch64 (open-telemetry#218)

* Add PID as an attribute in each sample (open-telemetry#212)

* ebpf: increase number of stack delta buckets (open-telemetry#231)

Signed-off-by: Florian Lehner <[email protected]>

* reporter: use htlhash attribute for profiling specific hash (open-telemetry#236)

Signed-off-by: Florian Lehner <[email protected]>

* reporter: drop fifo (open-telemetry#239)

Signed-off-by: Florian Lehner <[email protected]>

* Drop more unused code (open-telemetry#240)

* reporter: do not add empty attributes (open-telemetry#233)

Signed-off-by: Florian Lehner <[email protected]>

* controller: fix reporter interval mix up with monitor interval (open-telemetry#242)

* Extract reporter runloop (open-telemetry#228)

Co-authored-by: Christos Kalkanis <[email protected]>

* Extract lookupcgroupv2 out of the otlp reporter (open-telemetry#227)

* Add CPU id to trace and trace metadata (open-telemetry#249)

* reporter: don't expire actively used executables (open-telemetry#247)

* Remove legacy code from libpf.UnixTime64 (open-telemetry#252)

* Turn kernel module file parsing errors into warnings (open-telemetry#255)

Co-authored-by: Florian Lehner <[email protected]>

* readatbuf: add missing check when reading from tail chunk (open-telemetry#259)

* metrics: Don't send counters with 0 values (open-telemetry#246)

---------

Signed-off-by: Florian Lehner <[email protected]>
Co-authored-by: umanwizard <[email protected]>
Co-authored-by: Bhavna Jindal <[email protected]>
Co-authored-by: Florian Lehner <[email protected]>
Co-authored-by: Tim Rühsen <[email protected]>
Co-authored-by: Nayef Ghattas <[email protected]>
Co-authored-by: Damien Mathieu <[email protected]>
Co-authored-by: Christos Kalkanis <[email protected]>
Co-authored-by: Tommy Reilly <[email protected]>
Co-authored-by: Joel Höner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants