-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there any otel collector version that supports this new feature? #12
Comments
It seems that I need to modify the makefile of the otel-collector, and use the corresponding version of otel-proto, since this feature is not merged into the otel-proto yet, thus I can not simply change the version of otel-protocol in the makefile of otel-collector. https://github.com/open-telemetry/opentelemetry-collector/blob/main/Makefile#L185 |
petethepig/opentelemetry-collector#1 I guess this version probably can work, can the authors please verify it? or it there any way that can allow me to export the data with the current otel-collector? |
Hi @Lincyaw 👋 As you have mentioned, open-telemetry/opentelemetry-proto#534 is not merged yet and to my knowledge, there are no OTel collectors implementing this protocol yet. At the moment, I can not tell if petethepig/opentelemetry-collector#1 is based exactly on open-telemetry/opentelemetry-proto#534 or if a previous version is implemented. So we did not test this agent with petethepig/opentelemetry-collector#1. For the mean time we provide devfiler to visualize data. |
@Lincyaw You can print the logs to stdout, so you won't need to set up a remote RPC server. Does that meet your needs? |
It‘s merged meanwhile |
I see. The tag is experimental, so it also needs to change the otel-profiling-agent's implementation to adopt the experimental tag, otherwise when sending the messages, it will warn that the proto is not matched. |
Is there a issue for this (assigned) already? |
Not yet I think. I am also waiting/watching for the solution. |
There is ongoing work, around open-telemetry/opentelemetry-collector#10375, to bring the new OTel profiling signal into the OTel collector. |
I wouldn't expect the collector to support this before the end of the summer though. |
@Lincyaw Did you manage to get around the issue in the meanwhile somehow? |
Rather than require a match on the exact version, we should just match on major+minor, and fall back to the latest version if we don't find a result.
Hey @dmathieu, I saw that you were working on it, if I am correct. Do you know if it is available now for the collector? If not, do you have an idea if it will be released soon? |
Support for profiles in the collector will be available soon. |
I tried to run my own otel collector to collect the data, however, it shows that some of the new features of signal is not implemented.
The text was updated successfully, but these errors were encountered: