Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any otel collector version that supports this new feature? #12

Open
Lincyaw opened this issue Apr 17, 2024 · 13 comments
Open

Is there any otel collector version that supports this new feature? #12

Lincyaw opened this issue Apr 17, 2024 · 13 comments

Comments

@Lincyaw
Copy link

Lincyaw commented Apr 17, 2024

I tried to run my own otel collector to collect the data, however, it shows that some of the new features of signal is not implemented.

time="2024-04-17T20:41:17.626067005Z" level=error msg="Failed to handle mapping for PID 1700136, file /usr/bin/clickhouse: failed to load deltas: failed UpdateExeIDToStackDeltas for FileID e71a2d0df314abcd: no map available for 3256297 stack deltas"
time="2024-04-17T20:41:18.285213757Z" level=error msg="Failed to handle mapping for PID 1700137, file /usr/bin/clickhouse: failed to load deltas: failed UpdateExeIDToStackDeltas for FileID e71a2d0df314abcd: no map available for 3256297 stack deltas"
time="2024-04-17T20:41:23.997951426Z" level=info msg="Attached tracer program"
time="2024-04-17T20:41:24.050963144Z" level=info msg="Attached sched monitor"
time="2024-04-17T20:41:24.052807028Z" level=info msg="Environment variable KUBERNETES_SERVICE_HOST not set"
time="2024-04-17T20:41:24.632531045Z" level=error msg="Request failed: rpc error: code = Unimplemented desc = unknown service opentelemetry.proto.collector.profiles.v1.ProfilesService"
time="2024-04-17T20:41:25.882740002Z" level=error msg="Failed to handle mapping for PID 1700137, file /usr/bin/clickhouse: failed to load deltas: failed UpdateExeIDToStackDeltas for FileID e71a2d0df314abcd: no map available for 3256297 stack deltas"
time="2024-04-17T20:41:29.133657342Z" level=error msg="Request failed: rpc error: code = Unimplemented desc = unknown service opentelemetry.proto.collector.profiles.v1.ProfilesService"
time="2024-04-17T20:41:33.961619601Z" level=error msg="Request failed: rpc error: code = Unimplemented desc = unknown service opentelemetry.proto.collector.profiles.v1.ProfilesService"
time="2024-04-17T20:41:43.844658570Z" level=error msg="Request failed: rpc error: code = Unimplemented desc = unknown service opentelemetry.proto.collector.profiles.v1.ProfilesService"
time="2024-04-17T20:41:49.753826484Z" level=error msg="Request failed: rpc error: code = Unimplemented desc = unknown service opentelemetry.proto.collector.profiles.v1.ProfilesService"
^Ctime="2024-04-17T20:41:51.601494731Z" level=info msg="Stop processing ..."
time="2024-04-17T20:41:51.601518358Z" level=info msg="Exiting ..."
@Lincyaw
Copy link
Author

Lincyaw commented Apr 17, 2024

It seems that I need to modify the makefile of the otel-collector, and use the corresponding version of otel-proto, since this feature is not merged into the otel-proto yet, thus I can not simply change the version of otel-protocol in the makefile of otel-collector.

https://github.com/open-telemetry/opentelemetry-collector/blob/main/Makefile#L185

image

@Lincyaw
Copy link
Author

Lincyaw commented Apr 17, 2024

petethepig/opentelemetry-collector#1

I guess this version probably can work, can the authors please verify it? or it there any way that can allow me to export the data with the current otel-collector?

@florianl
Copy link
Contributor

Hi @Lincyaw 👋

As you have mentioned, open-telemetry/opentelemetry-proto#534 is not merged yet and to my knowledge, there are no OTel collectors implementing this protocol yet.

At the moment, I can not tell if petethepig/opentelemetry-collector#1 is based exactly on open-telemetry/opentelemetry-proto#534 or if a previous version is implemented. So we did not test this agent with petethepig/opentelemetry-collector#1.
We hope, that open-telemetry/opentelemetry-proto#534 gets merged soon and OTel collector and/or other implementations will use it.

For the mean time we provide devfiler to visualize data.

@cfc4n
Copy link

cfc4n commented Apr 18, 2024

@Lincyaw You can print the logs to stdout, so you won't need to set up a remote RPC server. Does that meet your needs?

@cforce
Copy link

cforce commented Jun 22, 2024

We hope, that https://github.com/open->telemetry/opentelemetry-proto/pull/534 gets >merged soon and OTel collector and/or other >implementations will use it.

It‘s merged meanwhile

@Lincyaw
Copy link
Author

Lincyaw commented Jun 23, 2024

We hope, that https://github.com/open->telemetry/opentelemetry-proto/pull/534 gets >merged soon and OTel collector and/or other >implementations will use it.

It‘s merged meanwhile

I see. The tag is experimental, so it also needs to change the otel-profiling-agent's implementation to adopt the experimental tag, otherwise when sending the messages, it will warn that the proto is not matched.

@cforce
Copy link

cforce commented Jun 23, 2024

Is there a issue for this (assigned) already?

@Lincyaw
Copy link
Author

Lincyaw commented Jun 23, 2024

Not yet I think. I am also waiting/watching for the solution.

@florianl
Copy link
Contributor

There is ongoing work, around open-telemetry/opentelemetry-collector#10375, to bring the new OTel profiling signal into the OTel collector.

@dmathieu
Copy link
Member

I wouldn't expect the collector to support this before the end of the summer though.

@ShimiTaNaka
Copy link

@Lincyaw Did you manage to get around the issue in the meanwhile somehow?

umanwizard added a commit to umanwizard/otel-profiling-agent that referenced this issue Oct 9, 2024
Rather than require a match on the exact version, we should just match
on major+minor, and fall back to the latest version if we don't find a result.
@HuseyinCoinmerce
Copy link

HuseyinCoinmerce commented Oct 17, 2024

I wouldn't expect the collector to support this before the end of the summer though.

Hey @dmathieu, I saw that you were working on it, if I am correct. Do you know if it is available now for the collector? If not, do you have an idea if it will be released soon?

@dmathieu
Copy link
Member

Support for profiles in the collector will be available soon.
However, it won't be stable for several weeks yet, and there are coming breaking changes, which makes using it not easy. Proper use in production won't be possible for a few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants