Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistent naming for Extension methods #931

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Fix inconsistent naming for Extension methods #931

merged 3 commits into from
Jul 27, 2020

Conversation

cijothomas
Copy link
Member

Fixes #.

Changes

Changes OpenTelemetryBuilderExtensions to TracerProviderBuilderExtensions.

Please provide a brief description of the changes here. Update the
CHANGELOG.md for non-trivial changes.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

@cijothomas cijothomas requested a review from a team July 27, 2020 15:08
reyang
reyang approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit 871d56c into open-telemetry:master Jul 27, 2020
@cijothomas cijothomas deleted the cijothomas/minorpart9 branch July 27, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@eddynaka eddynaka eddynaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cijothomas @eddynaka @reyang