Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable netcoreapp2.1 #780

Merged
merged 4 commits into from
Jul 8, 2020
Merged

Enable netcoreapp2.1 #780

merged 4 commits into from
Jul 8, 2020

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented Jul 7, 2020

Changes

  • enable netcoreapp2.1 for all test projects that are possible
  • added new TestApp for netcoreapp2.1

References:

Checklist

  • I ran Unit Tests locally.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

The PR will automatically request reviews from code owners and trigger CI build and tests.

@eddynaka eddynaka requested a review from a team July 7, 2020 15:13
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #780 into master will decrease coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
- Coverage   70.94%   70.87%   -0.08%     
==========================================
  Files         223      228       +5     
  Lines        7063     7117      +54     
  Branches     1192     1185       -7     
==========================================
+ Hits         5011     5044      +33     
- Misses       1731     1756      +25     
+ Partials      321      317       -4     
Impacted Files Coverage Δ
...pp.AspNetCore.2.1/Controllers/ForwardController.cs 0.00% <0.00%> (ø)
...App.AspNetCore.2.1/Controllers/ValuesController.cs 40.00% <40.00%> (ø)
test/TestApp.AspNetCore.2.1/Program.cs 50.00% <50.00%> (ø)
test/TestApp.AspNetCore.2.1/Startup.cs 92.85% <92.85%> (ø)
test/TestApp.AspNetCore.2.1/CallbackMiddleware.cs 100.00% <100.00%> (ø)
src/OpenTelemetry.Api/Metrics/LabelSet.cs 50.00% <0.00%> (-50.00%) ⬇️
src/OpenTelemetry/Metrics/Export/MetricData.cs 50.00% <0.00%> (-50.00%) ⬇️
...enTelemetry/Metrics/Export/PushMetricController.cs 69.44% <0.00%> (-5.56%) ⬇️
... and 9 more

@eddynaka eddynaka marked this pull request as draft July 7, 2020 15:27
@eddynaka eddynaka closed this Jul 7, 2020
@eddynaka eddynaka reopened this Jul 7, 2020
@eddynaka
Copy link
Contributor Author

eddynaka commented Jul 7, 2020

closing and reopening. we have one test that keeps working/not working from time to time.

@eddynaka eddynaka closed this Jul 7, 2020
@eddynaka eddynaka reopened this Jul 7, 2020
@eddynaka eddynaka marked this pull request as ready for review July 7, 2020 18:10
eddynaka and others added 4 commits July 7, 2020 21:21
updating yml

Revert "updating yml"

This reverts commit 391f3baadbca0de4b3e2d78b35db38eb7e7bddbc.

installing dotnet 2.1 and 3.1

updating yml to enable multiple dotnet versions

adding matrix condition

disable dotnet 2.1 for windows

removing unused package reference

Revert "removing unused package reference"

This reverts commit 0d898aa044f916743da613a83539f568bff3ad49.

updating yml

adding cov.yml to sln

Add resources to instrumentation (#779)

* Add resources to instrumentation

* Unit test activitysourcedapter

Co-authored-by: Sergey Kanzhelev <[email protected]>

disabling ubuntu-latest to codecoverage

removing extra steps

adding codecov.yml

moving file
@cijothomas cijothomas merged commit 0973b3e into open-telemetry:master Jul 8, 2020
@eddynaka eddynaka deleted the feature/enable-netcoreapp2.1 branch July 9, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants