Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[console] Switch to TagWriter for handling of tags/attributes #5596

Merged
merged 2 commits into from
May 9, 2024

Conversation

CodeBlanch
Copy link
Member

Follow-up to #5476
Relates to #5475

Changes

  • Switch from TagTransformer to TagWriter design in ConsoleExporter project

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 8.00000% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 85.69%. Comparing base (6250307) to head (8162f17).
Report is 214 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5596      +/-   ##
==========================================
+ Coverage   83.38%   85.69%   +2.31%     
==========================================
  Files         297      254      -43     
  Lines       12531    10979    -1552     
==========================================
- Hits        10449     9409    -1040     
+ Misses       2082     1570     -512     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 85.74% <8.00%> (?)
unittests-Solution-Stable 85.40% <8.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../OpenTelemetry.Exporter.Console/ConsoleExporter.cs 66.66% <50.00%> (-8.34%) ⬇️
...metry.Exporter.Console/ConsoleLogRecordExporter.cs 0.00% <0.00%> (ø)
...emetry.Exporter.Console/ConsoleActivityExporter.cs 48.33% <0.00%> (+0.05%) ⬆️
...elemetry.Exporter.Console/ConsoleMetricExporter.cs 0.00% <0.00%> (ø)
...xporter.Console/Implementation/ConsoleTagWriter.cs 11.53% <11.53%> (ø)

... and 112 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 49d70e0 into open-telemetry:main May 9, 2024
31 checks passed
@CodeBlanch CodeBlanch deleted the console-tagwriter branch May 9, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants