-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.OpenTelemetryProtocol] User agent changed to OTel-OTLP-Exporter-Dotnet/{NuGet Package Version} #5528
[Exporter.OpenTelemetryProtocol] User agent changed to OTel-OTLP-Exporter-Dotnet/{NuGet Package Version} #5528
Conversation
@CodeBlanch, @reyang, FYI |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5528 +/- ##
==========================================
+ Coverage 83.38% 85.52% +2.13%
==========================================
Files 297 289 -8
Lines 12531 12579 +48
==========================================
+ Hits 10449 10758 +309
+ Misses 2082 1821 -261
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Vishwesh Bankwar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Follow up to #5498
Changes
Handles following comments:
Merge requirement checklist
[ ] Unit tests added/updatedCHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)