-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp] Remove AppContext verification when using grpc + insecure endpoints #5486
[otlp] Remove AppContext verification when using grpc + insecure endpoints #5486
Conversation
…rt in examples library targets .NET8. The switch is not needed
…er.Http2UnencryptedSupport The lowest supported version is .NET6. Switch is not needed
….Http.SocketsHttpHandler.Http2UnencryptedSupport .NET Core 3.x is no longer supported
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5486 +/- ##
==========================================
+ Coverage 83.38% 85.53% +2.14%
==========================================
Files 297 289 -8
Lines 12531 12593 +62
==========================================
+ Hits 10449 10771 +322
+ Misses 2082 1822 -260
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - @Kielek Could you please update the PR description with the link https://learn.microsoft.com/en-us/aspnet/core/grpc/troubleshoot?view=aspnetcore-8.0#call-insecure-grpc-services-with-net-core-client
Regarding the question on using netstandard2.0
with netcoreapp3.1
, we do not support this scenario. #3767
Done.
Great! All commits can be merged. |
...metry.Exporter.OpenTelemetryProtocol/Implementation/ExportClient/ExporterClientValidation.cs
Show resolved
Hide resolved
Co-authored-by: Mikel Blanchard <[email protected]>
Fixes N/A
Design discussion issue N/A
Changes
Drop all references to
System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport
. It was needed for .NET Core 3.x only. Now, only .NET6+ is supported so the code can be removed.For sure 2 first commits can be merged. I have some doubts about 7379247. Formally, there is no support to .NET Core 3.x in this repository but exporter package is targeted to netstandard2.0 and netstndard2.1. Both can be technically referenced by .NET Core 3.x.Not supported per discsion in this PR.Merge requirement checklist
[ ] AppropriateN/ACHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)N/A