Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNetCore] Fix span names when http.request.method is reporter as _OTHER #5484

Merged
merged 8 commits into from
Mar 29, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Mar 28, 2024

Fixes #5461
Design discussion issue #

Changes

  • Fixed an issue for span names when http.request.method is reporter as _OTHER.
    Now, span names starts with HTTP, previously it was started by _OTHER.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.14%. Comparing base (6250307) to head (44705c2).
Report is 152 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    open-telemetry/opentelemetry-dotnet#5484      +/-   ##
==========================================
+ Coverage   83.38%   85.14%   +1.75%     
==========================================
  Files         297      290       -7     
  Lines       12531    12588      +57     
==========================================
+ Hits        10449    10718     +269     
+ Misses       2082     1870     -212     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 24.15% <100.00%> (?)
unittests-Instrumentation-Stable 24.17% <100.00%> (?)
unittests-Solution-Experimental 85.56% <100.00%> (?)
unittests-Solution-Stable 85.58% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 89.79% <100.00%> (+0.21%) ⬆️
...tp/Implementation/HttpHandlerDiagnosticListener.cs 70.63% <100.00%> (-0.24%) ⬇️
...plementation/HttpWebRequestActivitySource.netfx.cs 80.12% <100.00%> (-0.66%) ⬇️

... and 74 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review March 28, 2024 07:33
@Kielek Kielek requested a review from a team March 28, 2024 07:34
@CodeBlanch CodeBlanch merged commit 1374a7d into open-telemetry:main Mar 29, 2024
49 checks passed
@Kielek Kielek deleted the aspnetcore-span-names branch March 29, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Instruementation.AspNetCore] Fix span names according to sem conv 1.24.0
4 participants