-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.Zipkin] Use new attributes to propagate scope #5473
[Exporter.Zipkin] Use new attributes to propagate scope #5473
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5473 +/- ##
==========================================
+ Coverage 83.38% 85.42% +2.04%
==========================================
Files 297 289 -8
Lines 12531 12511 -20
==========================================
+ Hits 10449 10688 +239
+ Misses 2082 1823 -259
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Mikel Blanchard <[email protected]>
Co-authored-by: Vishwesh Bankwar <[email protected]>
Changes
Use new attributes to propagate scope according to https://github.com/open-telemetry/opentelemetry-specification/blob/v1.31.0/specification/common/mapping-to-non-otlp.md#instrumentationscope
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)