Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNetCore, Instrumentation.Http] Fix http.request.method_original attribute #5471

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Mar 25, 2024

Fixes open-telemetry/opentelemetry-dotnet-contrib#1607 (comment)
Design discussion issue #

Changes

Propagates changes from open-telemetry/opentelemetry-dotnet-contrib#1607 related to http.request.method_original

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek changed the title [Instrumentation.AspNetCore, Instrumentation.Http] Fix http.request.m… [Instrumentation.AspNetCore, Instrumentation.Http] Fix http.request.method_original attribute Mar 25, 2024
@Kielek Kielek force-pushed the aspnetcore-request-method-tags branch from 0f3cead to e94149e Compare March 25, 2024 09:07
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (6250307) to head (bb346b1).
Report is 147 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5471      +/-   ##
==========================================
+ Coverage   83.38%   85.53%   +2.15%     
==========================================
  Files         297      290       -7     
  Lines       12531    12606      +75     
==========================================
+ Hits        10449    10783     +334     
+ Misses       2082     1823     -259     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 24.19% <ø> (?)
unittests-Instrumentation-Stable 24.22% <ø> (?)
unittests-Solution-Experimental 85.48% <ø> (?)
unittests-Solution-Stable 85.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 64 files with indirect coverage changes

@Kielek Kielek force-pushed the aspnetcore-request-method-tags branch from e94149e to 41120bf Compare March 25, 2024 09:32
@Kielek Kielek marked this pull request as ready for review March 25, 2024 09:41
@Kielek Kielek requested a review from a team March 25, 2024 09:41
@Kielek
Copy link
Contributor Author

Kielek commented Mar 25, 2024

@vishweshbankwar, first part of propagation fixes from open-telemetry/opentelemetry-dotnet-contrib#1607. Please review, and merge if possible.

@utpilla utpilla merged commit dfdbf01 into open-telemetry:main Mar 27, 2024
49 checks passed
@Kielek Kielek deleted the aspnetcore-request-method-tags branch March 27, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants