Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Add experimental feature flag for enabling retries #5435

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Mar 11, 2024

Towards #1779
Design discussion issue #

Changes

Adds OTEL_DOTNET_EXPERIMENTAL_OTLP_ENABLE_INMEMORY_RETRY to enable retries in case of transient errors.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (6250307) to head (0b4496c).
Report is 129 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5435      +/-   ##
==========================================
+ Coverage   83.38%   84.87%   +1.48%     
==========================================
  Files         297      284      -13     
  Lines       12531    12224     -307     
==========================================
- Hits        10449    10375      -74     
+ Misses       2082     1849     -233     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 84.85% <100.00%> (?)
unittests-Solution-Stable 84.62% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...etryProtocol/Implementation/ExperimentalOptions.cs 100.00% <100.00%> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 97.08% <100.00%> (+0.72%) ⬆️
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 94.82% <100.00%> (+1.21%) ⬆️
....Exporter.OpenTelemetryProtocol/OtlpLogExporter.cs 91.17% <100.00%> (+2.28%) ⬆️
...lemetryProtocol/OtlpLogExporterHelperExtensions.cs 70.88% <ø> (-0.19%) ⬇️
...porter.OpenTelemetryProtocol/OtlpMetricExporter.cs 83.87% <100.00%> (+0.53%) ⬆️
...nTelemetryProtocol/OtlpMetricExporterExtensions.cs 99.05% <100.00%> (+0.04%) ⬆️
...xporter.OpenTelemetryProtocol/OtlpTraceExporter.cs 88.88% <100.00%> (-2.29%) ⬇️
...metryProtocol/OtlpTraceExporterHelperExtensions.cs 96.87% <100.00%> (+0.20%) ⬆️

... and 58 files with indirect coverage changes

@vishweshbankwar vishweshbankwar changed the title Add experimental options to trace and metric exporter for retry [otlp] Add experimental options to trace and metric exporter for retry Mar 12, 2024
@vishweshbankwar vishweshbankwar changed the title [otlp] Add experimental options to trace and metric exporter for retry [otlp] Add experimental feature flag for enabling retries Mar 12, 2024
@vishweshbankwar vishweshbankwar marked this pull request as ready for review March 12, 2024 20:28
@vishweshbankwar vishweshbankwar requested a review from a team March 12, 2024 20:28
@vishweshbankwar vishweshbankwar added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Mar 12, 2024
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a CHANGELOG update.

@utpilla utpilla merged commit eb2dc44 into open-telemetry:main Mar 13, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants