-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp] Add Retry Handler #5433
[otlp] Add Retry Handler #5433
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5433 +/- ##
==========================================
+ Coverage 83.38% 84.81% +1.42%
==========================================
Files 297 284 -13
Lines 12531 12206 -325
==========================================
- Hits 10449 10352 -97
+ Misses 2082 1854 -228
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...er.OpenTelemetryProtocol/Implementation/Transmission/OtlpExporterRetryTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
…n/Transmission/OtlpExporterRetryTransmissionHandler.cs Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/Transmission/RetryHelper.cs
Outdated
Show resolved
Hide resolved
...er.OpenTelemetryProtocol/Implementation/Transmission/OtlpExporterRetryTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/MockCollectorIntegrationTests.cs
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/MockCollectorIntegrationTests.cs
Show resolved
Hide resolved
….com/vishweshbankwar/opentelemetry-dotnet into vibankwa/add-retryhandler-with-tests
…n/Transmission/OtlpExporterRetryTransmissionHandler.cs Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
@@ -186,16 +188,6 @@ public static IEnumerable<object[]> GetGrpcTestCases() | |||
}, | |||
expectedRetryAttempts: 9), | |||
}; | |||
|
|||
yield return new[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alanwest - I did not quite understand the significance of this test. It was testing that we would retry if the deadline is not set and server responds with a very high delay. We should not run in to this case as we would always have the deadline set, let me know if I am missing something here.
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ExportClient/OtlpRetry.cs
Outdated
Show resolved
Hide resolved
...er.OpenTelemetryProtocol/Implementation/Transmission/OtlpExporterRetryTransmissionHandler.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/Transmission/RetryHelper.cs
Show resolved
Hide resolved
….com/vishweshbankwar/opentelemetry-dotnet into vibankwa/add-retryhandler-with-tests
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ExportClient/OtlpRetry.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/MockCollectorIntegrationTests.cs
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/MockCollectorIntegrationTests.cs
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/MockCollectorIntegrationTests.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/MockCollectorIntegrationTests.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/MockCollectorIntegrationTests.cs
Outdated
Show resolved
Hide resolved
…llectorIntegrationTests.cs Co-authored-by: Utkarsh Umesan Pillai <[email protected]>
Towards #1779
Design discussion issue #
Changes
Adds a retry transmission handler for retrying transient errors. It covers both http and grpc protocol.
Planning to do a follow up PR which will add the ability to opt-in for retries via an experimental environment variable.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes