Rename SqlClientInstrumentationOptions to SqlClientTraceInstrumentationOptions

[Kielek]

Fixes #
Design discussion issue #
Propagate changes from #5109

Changes

Rename SqlClientInstrumentationOptions to SqlClientTraceInstrumentationOptions.

Merge requirement checklist

• CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
• Unit tests added/updated
• Appropriate CHANGELOG.md files updated for non-trivial changes
• Changes in public API reviewed (if applicable)

[codecov]

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (6250307) 83.38% compared to head (bfd95e3) 82.98%.
Report is 45 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5285      +/-   ##
==========================================
- Coverage   83.38%   82.98%   -0.40%     
==========================================
  Files         297      272      -25     
  Lines       12531    11973     -558     
==========================================
- Hits        10449     9936     -513     
+ Misses       2082     2037      -45     

Flag	Coverage Δ
unittests	?
unittests-Instrumentation-Experimental	24.66% <47.22%> (?)
unittests-Instrumentation-Stable	24.66% <47.22%> (?)
unittests-Solution-Experimental	82.72% <76.92%> (?)
unittests-Solution-Stable	82.97% <76.92%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
....Api/Context/Propagation/TraceContextPropagator.cs	90.00% <100.00%> (+0.52%)	⬆️
...etryProtocol/Implementation/ExperimentalOptions.cs	100.00% <ø> (ø)
...tation/OpenTelemetryProtocolExporterEventSource.cs	100.00% <100.00%> (ø)
...rotocol/Implementation/OtlpLogRecordTransformer.cs	93.45% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs	89.79% <100.00%> (+0.21%)	⬆️
...AspNetCore/Implementation/HttpInMetricsListener.cs	89.74% <100.00%> (+0.26%)	⬆️
...ntation.GrpcNetClient/GrpcClientInstrumentation.cs	100.00% <100.00%> (ø)
...NetClient/GrpcClientTraceInstrumentationOptions.cs	100.00% <ø> (ø)
...ent/Implementation/GrpcClientDiagnosticListener.cs	75.80% <100.00%> (-2.77%)	⬇️
...n.GrpcNetClient/TracerProviderBuilderExtensions.cs	100.00% <100.00%> (ø)
... and 13 more

... and 30 files with indirect coverage changes

[smoms]

May I understand how come a breking change like this is just increasing a patch number? Does not follow semantic release? tks

[vishweshbankwar]

May I understand how come a breking change like this is just increasing a patch number? Does not follow semantic release? tks

This component is now moved to https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main

Please take a look at this note: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/47b667acf8cde47aa73fc6d28b609ebb3aeca8d3/src/OpenTelemetry.Instrumentation.SqlClient/README.md?plain=1#L20-L29

[smoms]

@vishweshbankwar thanks. Does it mean that now the package is being moved to stable?

[cijothomas]

@vishweshbankwar thanks. Does it mean that now the package is being moved to stable?

If you are referring to https://github.com/open-telemetry/opentelemetry-dotnet-contrib/tree/main/src/OpenTelemetry.Instrumentation.SqlClient, then no. It is not moved to stable.