Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GrpcClientInstrumentationOptions to GrpcClientTraceInstrumentationOptions #5272

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jan 29, 2024

Fixes #
Design discussion issue #
Propagate changes from #5109

Changes

Rename GrpcClientInstrumentationOptions to GrpcClientTraceInstrumentationOptions.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team January 29, 2024 09:27
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (6250307) 83.38% compared to head (1440b22) 82.97%.
Report is 43 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5272      +/-   ##
==========================================
- Coverage   83.38%   82.97%   -0.42%     
==========================================
  Files         297      272      -25     
  Lines       12531    11974     -557     
==========================================
- Hits        10449     9935     -514     
+ Misses       2082     2039      -43     
Flag Coverage Δ
unittests ?
unittests-Solution-Stable 82.78% <74.69%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
....Api/Context/Propagation/TraceContextPropagator.cs 90.00% <100.00%> (+0.52%) ⬆️
...etryProtocol/Implementation/ExperimentalOptions.cs 100.00% <ø> (ø)
...tation/OpenTelemetryProtocolExporterEventSource.cs 100.00% <100.00%> (ø)
...rotocol/Implementation/OtlpLogRecordTransformer.cs 93.45% <100.00%> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 89.79% <100.00%> (+0.21%) ⬆️
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.74% <100.00%> (+0.26%) ⬆️
...ntation.GrpcNetClient/GrpcClientInstrumentation.cs 100.00% <100.00%> (ø)
...NetClient/GrpcClientTraceInstrumentationOptions.cs 100.00% <ø> (ø)
...ent/Implementation/GrpcClientDiagnosticListener.cs 75.80% <100.00%> (-2.77%) ⬇️
...n.GrpcNetClient/TracerProviderBuilderExtensions.cs 100.00% <100.00%> (ø)
... and 10 more

... and 31 files with indirect coverage changes

@alanwest alanwest merged commit 52a03b1 into open-telemetry:main Jan 30, 2024
44 checks passed
@Kielek Kielek deleted the instrumentation-grpcnetclient-rename-options-class branch January 30, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants