Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Avoid duplicate ToString calls in redaction log processor #5248

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

CodeBlanch
Copy link
Member

nt

@CodeBlanch CodeBlanch requested a review from a team January 23, 2024 22:29
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6250307) 83.38% compared to head (663185f) 83.11%.
Report is 24 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5248      +/-   ##
==========================================
- Coverage   83.38%   83.11%   -0.27%     
==========================================
  Files         297      271      -26     
  Lines       12531    11970     -561     
==========================================
- Hits        10449     9949     -500     
+ Misses       2082     2021      -61     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 83.08% <100.00%> (?)
unittests-Solution-Stable 83.11% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 89.72% <100.00%> (+0.14%) ⬆️
...AspNetCore/Implementation/HttpInMetricsListener.cs 89.47% <ø> (ø)
...plementation/HttpWebRequestActivitySource.netfx.cs 80.77% <100.00%> (ø)
...emetry/Metrics/Exemplar/SimpleExemplarReservoir.cs 80.43% <100.00%> (ø)

... and 34 files with indirect coverage changes

@alanwest alanwest merged commit 0a77cc3 into open-telemetry:main Jan 24, 2024
27 of 30 checks passed
@CodeBlanch CodeBlanch deleted the logs-redaction-doc-tweak branch January 24, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants