Docs - logging best practice #5246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5246 +/- ##
==========================================
- Coverage 83.38% 83.12% -0.27%
==========================================
Files 297 271 -26
Lines 12531 11970 -561
==========================================
- Hits 10449 9950 -499
+ Misses 2082 2020 -62
Flags with carried forward coverage won't be shown. Click here to find out more.
|
cijothomas
approved these changes
Jan 23, 2024
CodeBlanch
reviewed
Jan 23, 2024
CodeBlanch
reviewed
Jan 23, 2024
Comment on lines
+51
to
+53
| * Starting from version `3.1.0`, the .NET runtime team is holding a high bar for | ||
| backward compatibility on `Microsoft.Extensions.Logging` even during major | ||
| version bumps, so compatibility is not a concern here. |
There was a problem hiding this comment.
I think "high bar" might not be clear to everyone. Maybe something like...
- Starting from version
3.1.0the .NET runtime team has committed to preserve backwards compatibility on theMicrosoft.Extensions.Loggingpackages. There will be no breaking changes (within reason) across major version bumps.
There was a problem hiding this comment.
I don't think we can put such strong statement #4920 (comment).
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the initial doc for logging best practices.
Updated the logging benchmark to reflect the latest recommendations.