Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AspNetCore] Fix changelog entry and remove package reference #5241

Merged

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Jan 22, 2024

Fixes #
Design discussion issue #

Changes

Moved changelog entry to its corresponding project and addressed unresolved item from #5136 (comment) (Package reference is not needed to use Features in net6.0)

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar requested a review from a team January 22, 2024 17:05
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6250307) 83.38% compared to head (c3bb42e) 83.19%.
Report is 19 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5241      +/-   ##
==========================================
- Coverage   83.38%   83.19%   -0.20%     
==========================================
  Files         297      271      -26     
  Lines       12531    11970     -561     
==========================================
- Hits        10449     9958     -491     
+ Misses       2082     2012      -70     
Flag Coverage Δ
unittests ?
unittests-Instrumentation-Experimental 25.07% <83.33%> (?)
unittests-Instrumentation-Stable 25.07% <83.33%> (?)
unittests-Solution-Experimental 83.18% <100.00%> (?)
unittests-Solution-Stable 83.08% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 89.72% <100.00%> (+0.14%) ⬆️
...plementation/HttpWebRequestActivitySource.netfx.cs 80.77% <100.00%> (ø)
...emetry/Metrics/Exemplar/SimpleExemplarReservoir.cs 80.43% <100.00%> (ø)

... and 33 files with indirect coverage changes

@vishweshbankwar vishweshbankwar changed the title Fix changelog entry and remove package reference [Instrumentation.AspNetCore] Fix changelog entry and remove package reference Jan 22, 2024
@alanwest alanwest merged commit 00c3e58 into open-telemetry:main Jan 22, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants