Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed usage of Mock<BaseProcessor> #5095

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

ngruson
Copy link
Contributor

@ngruson ngruson commented Nov 29, 2023

Changes

On ask of @vishweshbankwar, the usage of Mock<BaseProcessor> was removed in OpenTelemetry.Instrumentation.Http.Tests.
Instead, InMemoryExporter is used to verify exported activities.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@ngruson ngruson requested a review from a team November 29, 2023 17:36
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #5095 (6a2db61) into main (4e390e3) will increase coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head 6a2db61 differs from pull request most recent head c3215a9. Consider uploading reports for the commit c3215a9 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5095      +/-   ##
==========================================
+ Coverage   83.15%   83.28%   +0.12%     
==========================================
  Files         296      296              
  Lines       12351    12351              
==========================================
+ Hits        10271    10287      +16     
+ Misses       2080     2064      -16     
Flag Coverage Δ
unittests 83.28% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ngruson!. For a separate PR, see if you can get rid of Mock propagator also.

@utpilla
Copy link
Contributor

utpilla commented Nov 29, 2023

Thanks @ngruson! Could you also remove the package reference to Moq from the csproj:

@utpilla
Copy link
Contributor

utpilla commented Nov 29, 2023

Thanks @ngruson! Could you also remove the package reference to Moq from the csproj:

Never mind! I got to know from @vishweshbankwar that this project still uses Moq for the propagator tests.

@utpilla utpilla merged commit 79aa39f into open-telemetry:main Nov 29, 2023
39 checks passed
@ngruson
Copy link
Contributor Author

ngruson commented Nov 29, 2023

I will do so in the next PR ;)

@vishweshbankwar
Copy link
Member

I will do so in the next PR ;)

@ngruson If you are able to remove the mock propagator part, please also check other test projects where it is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants