-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed usage of Mock<BaseProcessor> #5095
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5095 +/- ##
==========================================
+ Coverage 83.15% 83.28% +0.12%
==========================================
Files 296 296
Lines 12351 12351
==========================================
+ Hits 10271 10287 +16
+ Misses 2080 2064 -16
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ngruson!. For a separate PR, see if you can get rid of Mock propagator also.
Never mind! I got to know from @vishweshbankwar that this project still uses |
I will do so in the next PR ;) |
@ngruson If you are able to remove the mock propagator part, please also check other test projects where it is used. |
Changes
On ask of @vishweshbankwar, the usage of
Mock<BaseProcessor>
was removed inOpenTelemetry.Instrumentation.Http.Tests
.Instead,
InMemoryExporter
is used to verify exported activities.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes