Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASP.NET Core] Remove netstandard2.1 target #5094

Merged

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Nov 29, 2023

Fixes #
Design discussion issue #

Changes

Removes netstandard2.1 target.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 29, 2023 17:26
@vishweshbankwar vishweshbankwar requested a review from a team November 29, 2023 17:26
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #5094 (cac7edb) into main (6a829dd) will increase coverage by 0.15%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head cac7edb differs from pull request most recent head 3a306c6. Consider uploading reports for the commit 3a306c6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5094      +/-   ##
==========================================
+ Coverage   83.15%   83.30%   +0.15%     
==========================================
  Files         296      296              
  Lines       12340    12326      -14     
==========================================
+ Hits        10261    10268       +7     
+ Misses       2079     2058      -21     
Flag Coverage Δ
unittests 83.30% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ion.AspNetCore/AspNetCoreInstrumentationOptions.cs 100.00% <ø> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 88.88% <ø> (+13.88%) ⬆️

... and 11 files with indirect coverage changes

@utpilla utpilla merged commit 4f73d2b into open-telemetry:main Nov 29, 2023
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants