Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test packages and global.json to net8.0 rc.2 #5000

Merged

Conversation

vishweshbankwar
Copy link
Member

Fixes #
Design discussion issue #

Changes

Updates test packages to rc.2 and global.json min version.

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar marked this pull request as ready for review October 27, 2023 17:07
@vishweshbankwar vishweshbankwar requested a review from a team October 27, 2023 17:07
@vishweshbankwar vishweshbankwar changed the title updates to rc.2 update test packages and global.json to rc.2 Oct 27, 2023
@vishweshbankwar vishweshbankwar changed the title update test packages and global.json to rc.2 update test packages and global.json to net8.0 rc.2 Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #5000 (9bfe9ed) into main (74ad003) will decrease coverage by 0.10%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5000      +/-   ##
==========================================
- Coverage   83.45%   83.35%   -0.10%     
==========================================
  Files         295      295              
  Lines       12339    12339              
==========================================
- Hits        10297    10285      -12     
- Misses       2042     2054      +12     
Flag Coverage Δ
unittests 83.35% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@utpilla utpilla merged commit d76aa77 into open-telemetry:main Oct 27, 2023
34 checks passed
global.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants