Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve changelog to indicate which version of sdk #4964

Closed
wants to merge 1 commit into from

Conversation

cijothomas
Copy link
Member

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@@ -3,7 +3,7 @@
## Unreleased

* Introduced a new metric, `http.server.request.duration` measured in seconds.
The OTel SDK
The OTel SDK versions starting 1.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't read easily.
Try instead:

The OTel SDK (starting with version 1.6.0) applies custom histogram buckets ...

or

Starting with version 1.6.0, The OTel SDK applies custom.....

@TimothyMothra
Copy link
Contributor

Whatever change is made here should also be made in the Instrumentation.Http changelog.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Oct 26, 2023
@utpilla
Copy link
Contributor

utpilla commented Oct 26, 2023

Closed in favor of #4991

@utpilla utpilla closed this Oct 26, 2023
@reyang reyang deleted the cijothomas-patch-1 branch May 24, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants