[ASP.NET Core] Add net8 target #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main open-telemetry/opentelemetry-dotnet#4924 +/- ##
==========================================
+ Coverage 83.29% 83.32% +0.03%
==========================================
Files 295 295
Lines 12324 12324
==========================================
+ Hits 10265 10269 +4
+ Misses 2059 2055 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
utpilla
approved these changes
Oct 6, 2023
reyang
reviewed
Oct 6, 2023
| @@ -49,4 +49,8 @@ | |||
| <FrameworkReference Include="Microsoft.AspNetCore.App" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition="'$(TargetFramework)' == 'net8.0'"> | |||
There was a problem hiding this comment.
Yes, I will update this in my upcoming PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in order to add the metrics added to .NET8.0 in ASP.NET Core
open-telemetry/opentelemetry-dotnet-contrib#1753
open-telemetry/opentelemetry-dotnet-contrib#1753