-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Http] follow up from previous pr #4919
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4919 +/- ##
==========================================
+ Coverage 83.28% 83.30% +0.01%
==========================================
Files 295 295
Lines 12324 12324
==========================================
+ Hits 10264 10266 +2
+ Misses 2060 2058 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -31,7 +31,8 @@ | |||
* [http-metrics](https://github.com/open-telemetry/semantic-conventions/blob/2bad9afad58fbd6b33cc683d1ad1f006e35e4a5d/docs/http/http-metrics.md) | |||
|
|||
* Added support for publishing `http.client.duration` & | |||
`http.client.request.duration` metrics on .NET Framework | |||
`http.client.request.duration` metrics on .NET Framework. | |||
This supports `HttpClient` and `HttpWebRequest`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems redundant to me because everything in this library w.r.t. .NET Framework works for both HttpClient
& HttpWebRequest
.
This is an [Instrumentation | |
Library](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/glossary.md#instrumentation-library), | |
which instruments | |
[System.Net.Http.HttpClient](https://docs.microsoft.com/dotnet/api/system.net.http.httpclient) | |
and | |
[System.Net.HttpWebRequest](https://docs.microsoft.com/dotnet/api/system.net.httpwebrequest) | |
and collects metrics and traces about outgoing HTTP requests. |
I would say we should only mention it if it didn't work for one or the other for some reason.
Not a blocker for me, just sayin' 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -2,8 +2,8 @@ | |||
|
|||
## Unreleased | |||
|
|||
* Introduced a new metric, `http.client.request.duration` measured in seconds. | |||
The OTel SDK | |||
* Introduced a new metric for `HttpClient`, `http.client.request.duration` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Introduced a new metric for `HttpClient`, `http.client.request.duration` | |
* Introduced a new metric for `HttpClient` named `http.client.request.duration` which is measured in seconds |
Follow up to #4870
Changes
HttpClient
andHttpWebRequest
http.client.duration
andhttp.client.request.duration
.s
andms
).Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes