-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TFM bugs #4912
Fix TFM bugs #4912
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,7 +15,6 @@ | |
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="System.Net.Http" Condition="'$(TargetFramework)' == 'net462'" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm going to approve this but FYI what I really want is for the tests to verify everything works if the user decides to take the NuGet bits. But we should also make sure it works with the direct reference. Probably need to run the tests through both modes to do it correctly? Going to take a bit of effort to pull that off, not sure if the juice is worth the squeeze. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. With this PR, the test is going to cover the net462 framework reference of
Could you explain a bit more here? What's the main scenario and how big is the user base? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is definitely old, but I don't see anything on the NuGet saying it is deprecated and it has been downloaded 1.7B times so a lot of people are consuming it! The scenario is user takes a dependency on the NuGet and its bits are used instead of the shipped runtime assembly, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #4915 |
||
<PackageReference Include="Microsoft.NET.Test.Sdk" /> | ||
<PackageReference Include="Moq" /> | ||
<PackageReference Include="System.Text.Json" /> | ||
|
@@ -25,6 +24,10 @@ | |
</PackageReference> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<Reference Include="System.Net.Http" Condition="'$(TargetFramework)' == 'net462'" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<EmbeddedResource Include="http-out-test-cases.json"> | ||
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be used at all since it's a dead package https://www.nuget.org/packages/System.Net.Http/ (no updates since year 2018).