[build] Fix ordering issues with ExposeExperimentalFeatures compiler switch #4828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
reviewed
Sep 6, 2023
build/Common.prod.props
Outdated
| @@ -59,6 +59,19 @@ | |||
| <Message Importance="high" Text="**AssemblyVersionDebug** TargetFramework: $(TargetFramework), MinVerVersion: $(MinVerVersion), MinVerMajor: $(MinVerMajor), MinVerMinor: $(MinVerMinor), MinVerPatch: $(MinVerPatch), MinVerPreRelease: $(MinVerPreRelease), BuildNumber: $(BuildNumber), FileVersion: $(FileVersion), ExposeExperimentalFeatures: $(ExposeExperimentalFeatures)" /> | |||
| </Target> | |||
|
|
|||
| <Target Name="ResolveExposeExperimentalFeatures" AfterTargets="MinVer"> | |||
There was a problem hiding this comment.
Shouldn't this be run after AssemblyVersionTarget?
Suggested change
| <Target Name="ResolveExposeExperimentalFeatures" AfterTargets="MinVer"> | |
| <Target Name="ResolveExposeExperimentalFeatures" AfterTargets="AssemblyVersionTarget"> |
There was a problem hiding this comment.
I had that at first but AssemblyVersionTarget gets skipped for non-publish builds and we want this section to always run.
There was a problem hiding this comment.
When publishing builds, is the ordering guaranteed? We don't want this target to be evaluated before AssemblyVersionTarget.
There was a problem hiding this comment.
Not 100% sure about that, but I changed it so it now has a DependsOnTargets="AssemblyVersionTarget"
Codecov Report
@@ Coverage Diff @@
## main #4828 +/- ##
=======================================
Coverage 83.93% 83.93%
=======================================
Files 293 293
Lines 11998 11998
=======================================
Hits 10070 10070
Misses 1928 1928 |
utpilla
approved these changes
Sep 6, 2023
reyang
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
EXPOSE_EXPERIMENTAL_FEATURESconstant is set AFTER the version resolution logic fires