Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otlp log and trace exporter benchmarks #4807

Merged

Conversation

vishweshbankwar
Copy link
Member

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar changed the title Add benchmark log otlp Add otlp log exporter benchmark Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4807 (f5ad1cb) into main (6570696) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4807   +/-   ##
=======================================
  Coverage   83.54%   83.54%           
=======================================
  Files         292      292           
  Lines       11987    11987           
=======================================
  Hits        10014    10014           
  Misses       1973     1973           

@vishweshbankwar vishweshbankwar changed the title Add otlp log exporter benchmark Add otlp log and trace exporter benchmarks Aug 28, 2023
@vishweshbankwar vishweshbankwar marked this pull request as ready for review August 29, 2023 18:22
@vishweshbankwar vishweshbankwar requested a review from a team August 29, 2023 18:22
@reyang
Copy link
Member

reyang commented Aug 29, 2023

I have a general comment which doesn't have to block this PR: how do we consider the granularity of the Benchmark project? (take Stress Test for example, we don't shove all components' test logic into a single test project)

@vishweshbankwar
Copy link
Member Author

I have a general comment which doesn't have to block this PR: how do we consider the granularity of the Benchmark project? (take Stress Test for example, we don't shove all components' test logic into a single test project)

@reyang We do not have a set rule for deciding granularity. Not sure if we have a need for individual projects for benchmarks as its easier to use filtering during execution.

@utpilla utpilla merged commit bb1253e into open-telemetry:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants