-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpSemanticConventions - update helper class #4765
Merged
utpilla
merged 10 commits into
open-telemetry:main
from
TimothyMothra:4484_refactorHelper
Aug 17, 2023
Merged
HttpSemanticConventions - update helper class #4765
utpilla
merged 10 commits into
open-telemetry:main
from
TimothyMothra:4484_refactorHelper
Aug 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4765 +/- ##
==========================================
+ Coverage 82.27% 82.29% +0.02%
==========================================
Files 314 314
Lines 12923 12930 +7
==========================================
+ Hits 10632 10641 +9
+ Misses 2291 2289 -2
|
utpilla
reviewed
Aug 15, 2023
utpilla
reviewed
Aug 15, 2023
utpilla
approved these changes
Aug 15, 2023
vishweshbankwar
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4484
When I started on this, I was working off the older version of the spec in the old repo.
The current version of the spec in the new repo changed the environment variable to a comma-separated list.
Changes
HttpSemanticConventionsHelper
Shared\Shims\NullableAttributes
InlineData
withMemberData
so each test can use the same collection of test cases.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changesNote about duplicate values in the Environment Variable.
Edit: 8/14: The spec has been updated to specify if both
http
andhttp/dup
are specified,http/dup
will take precedence.open-telemetry/semantic-conventions#249
As of today, the only valid values are
http
(emit new attributes) andhttp/dup
(emit both new and old attributes).The spec doesn't define how to handle a scenario where a user provides both values in the CSV.
I opened an issue to get clarity: open-telemetry/semantic-conventions#240
In this scenario, Java takes a user-friendly approach of the approach of enabling both new and old attributes. I think we should do the same here.
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/32c5d4c26708ccaa20221bb6d687f56c9efde979/instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/SemconvStability.java#L26-L39