Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Convention changes. correct link and update changelog. #4655

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Semantic Convention changes. correct link and update changelog. #4655

merged 1 commit into from
Jul 13, 2023

Conversation

TimothyMothra
Copy link
Contributor

Design discussion issue #4484

Changes

  • correct the link to semantic conventions, using new repo.
  • update Changelog with semcon version number
  • update Changelog with missing links to PRs.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@TimothyMothra TimothyMothra requested a review from a team July 13, 2023 22:08
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #4655 (612e01a) into main (1d1c714) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4655      +/-   ##
==========================================
- Coverage   85.01%   84.99%   -0.03%     
==========================================
  Files         314      314              
  Lines       12715    12715              
==========================================
- Hits        10810    10807       -3     
- Misses       1905     1908       +3     
Impacted Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 90.47% <ø> (ø)
...AspNetCore/Implementation/HttpInMetricsListener.cs 64.70% <ø> (ø)
src/Shared/HttpSemanticConventionHelper.cs 80.00% <ø> (ø)

... and 2 files with indirect coverage changes

@utpilla utpilla merged commit 3f5c774 into open-telemetry:main Jul 13, 2023
@TimothyMothra TimothyMothra deleted the 4484_fixChangelog branch July 14, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants