Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up from https://github.com/open-telemetry/opentelemetry-dotnet/pull/4627 #4645

Merged

Conversation

vishweshbankwar
Copy link
Member

Fixes #
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar changed the title Follow up from #4627 Follow up from https://github.com/open-telemetry/opentelemetry-dotnet/pull/4627 Jul 7, 2023
Vishwesh Bankwar added 3 commits July 7, 2023 09:49
@vishweshbankwar vishweshbankwar marked this pull request as ready for review July 7, 2023 17:08
@vishweshbankwar vishweshbankwar requested a review from a team July 7, 2023 17:08
Vishwesh Bankwar added 2 commits July 7, 2023 10:36
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #4645 (9964d8c) into main (56fdb16) will decrease coverage by 0.06%.
The diff coverage is 90.00%.

❗ Current head 9964d8c differs from pull request most recent head 06f1290. Consider uploading reports for the commit 06f1290 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4645      +/-   ##
==========================================
- Coverage   84.95%   84.90%   -0.06%     
==========================================
  Files         314      314              
  Lines       12673    12689      +16     
==========================================
+ Hits        10766    10773       +7     
- Misses       1907     1916       +9     
Impacted Files Coverage Δ
...AspNetCore/Implementation/HttpInMetricsListener.cs 64.15% <83.33%> (+0.88%) ⬆️
...ementation/HttpHandlerMetricsDiagnosticListener.cs 72.22% <83.33%> (+0.34%) ⬆️
...tp/Implementation/HttpHandlerDiagnosticListener.cs 67.52% <87.50%> (+0.26%) ⬆️
...tation.AspNetCore/Implementation/HttpInListener.cs 90.47% <100.00%> (+0.20%) ⬆️

... and 3 files with indirect coverage changes

@utpilla utpilla merged commit ad08228 into open-telemetry:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants