Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert explicit net7 install #4565

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Revert explicit net7 install #4565

merged 2 commits into from
Jun 8, 2023

Conversation

masonyc
Copy link
Contributor

@masonyc masonyc commented Jun 8, 2023 •
edited
Loading

Fixes #
linked issue [/issues/3877]

Changes

Revert the explicit net7 install as runner-images has dotnet 7.0.302 now runner images - .Win2022 NET Core Tools

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@masonyc masonyc requested a review from a team June 8, 2023 04:31
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 8, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: masonyc / name: Yun Chen (93038d9)
  • ✅ login: utpilla / name: Utkarsh Umesan Pillai (3c915b9)

@masonyc masonyc marked this pull request as draft June 8, 2023 04:31
@masonyc masonyc marked this pull request as ready for review June 8, 2023 04:38
@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited
Loading

Codecov Report

Merging #4565 (3c915b9) into main (5ca8e98) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4565      +/-   ##
==========================================
+ Coverage   85.17%   85.22%   +0.05%     
==========================================
  Files         320      320              
  Lines       12678    12678              
==========================================
+ Hits        10798    10805       +7     
+ Misses       1880     1873       -7

see 4 files with indirect coverage changes

vishweshbankwar
vishweshbankwar approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masonyc

cijothomas
cijothomas approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and welcome to the OpenTelemetry .NET community!

@utpilla utpilla merged commit 2e57e2d into open-telemetry:main Jun 8, 2023
@masonyc masonyc deleted the masonyc/revert-explicit-net7-install branch June 8, 2023 23:56
mfogliatto pushed a commit to mfogliatto/opentelemetry-dotnet that referenced this pull request Jun 10, 2023
@masonyc @mfogliatto
Revert explicit net7 install (open-telemetry#4565)
b709ee5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@masonyc @cijothomas @vishweshbankwar @utpilla