Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AOT warnings for RuntimeContext #4542

Merged
merged 7 commits into from
Jun 6, 2023
Merged

Fix AOT warnings for RuntimeContext #4542

merged 7 commits into from
Jun 6, 2023

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jun 2, 2023 •
edited
Loading

Towards #3429

This PR introduces a Breaking change. This would no longer support assigning custom types to RuntimeContext.ContextSlotType.

Changes

  • Fix AOT warnings for RuntimeContext class
  • Drop support for custom implementations of RuntimeContextSlot<T>

Merge requirement checklist

  • Appropriate CHANGELOG.md files updated for non-trivial changes

@codecov
Copy link

codecov bot commented Jun 2, 2023 •
edited
Loading

Codecov Report

Merging #4542 (5dea4c9) into main (839de1a) will decrease coverage by 0.09%.
The diff coverage is 29.41%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4542      +/-   ##
==========================================
- Coverage   85.58%   85.50%   -0.09%     
==========================================
  Files         320      320              
  Lines       12615    12628      +13     
==========================================
+ Hits        10796    10797       +1     
- Misses       1819     1831      +12
Impacted Files Coverage Δ
src/OpenTelemetry.Api/Context/RuntimeContext.cs 47.82% <29.41%> (-15.82%) ⬇️

... and 4 files with indirect coverage changes

@utpilla utpilla marked this pull request as ready for review June 2, 2023 22:21
@utpilla utpilla requested a review from a team June 2, 2023 22:21
@utpilla utpilla mentioned this pull request Jun 2, 2023
Closed
4 tasks
eerhardt
eerhardt approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

alanwest
alanwest approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to add context for why this change is being made.

src/OpenTelemetry.Api/CHANGELOG.md Outdated Show resolved Hide resolved
@utpilla utpilla merged commit a457558 into open-telemetry:main Jun 6, 2023
mfogliatto pushed a commit to mfogliatto/opentelemetry-dotnet that referenced this pull request Jun 10, 2023
@utpilla @mfogliatto
Fix AOT warnings for RuntimeContext (open-telemetry#4542)
343cb01
@utpilla utpilla deleted the utpilla/Fix-AOT-Warnings-For-RuntimeContext branch November 23, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@eerhardt eerhardt eerhardt approved these changes

@Kielek Kielek Kielek left review comments

@Yun-Ting Yun-Ting Yun-Ting approved these changes

@alanwest alanwest alanwest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@utpilla @alanwest @Kielek @eerhardt @Yun-Ting @reyang